Remove $.ajax usage, add lorisFetch wrapper, and drop ajax-dependent vendor libs#10327
Closed
Montekkundan wants to merge 3 commits intoaces:mainfrom
Closed
Remove $.ajax usage, add lorisFetch wrapper, and drop ajax-dependent vendor libs#10327Montekkundan wants to merge 3 commits intoaces:mainfrom
Montekkundan wants to merge 3 commits intoaces:mainfrom
Conversation
Collaborator
|
Can you please split this up into multiple PRs that each do one thing and can be reviewed independently? A good set of PRs would be:
There seems to be changes unrelated to |
Author
|
Closing this PR in favor of split PRs, as requested. Opened:
Notes:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$.ajaxcalls withfetchand a newlorisFetchwrapper.Why
$.ajaxwas a primary blocker.lorisFetchcentralizes 401/login modal behavior so all fetch calls handle session expiry consistently.What changed
jslib/lorisFetch.jsand wired it into global usage.htdocs/js/jquery/jquery.autocomplete.js,htdocs/js/shims/*, andmodules/brainbrowser/js/html5-minc-viewer.min.js.Scope note
This PR removes
$.ajaxusage and ajax‑dependent vendor libs only.Other jQuery usages remain and should be handled in a separate refactor.
Verification
rg "\$\.ajax|\$\.get|\$\.post"returns no matches.Tests
npm run lint:js(warnings only, no errors)npm run build(warnings about bundle size; build succeeds)