[DQT] Add "Select All" option to Default Visits dropdown#10346
Open
arnav-makkar wants to merge 5 commits intoaces:mainfrom
Open
[DQT] Add "Select All" option to Default Visits dropdown#10346arnav-makkar wants to merge 5 commits intoaces:mainfrom
arnav-makkar wants to merge 5 commits intoaces:mainfrom
Conversation
Contributor
Agree the Remove All would be redundant since clicking the x on the Select component already does exactly that. I would just make the suggestion to place the Select All option in the top rather than the bottom because depending on the size of the list that option might be hidden behind the need to scroll down the list and I think it should be seen as soon the user opens it up. |
Contributor
Author
|
Thank you for the feedback. I have changed the logic to incorporate your suggestion. Please let me know if anything else is required. Screen.Recording.2026-02-18.at.01.20.02.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief summary of changes
Added the "Select All" option as requested.
I can add the "Remove All" option as well however it'll be quite redundant in my opinion.
Screen.Recording.2026-02-07.at.16.37.56.mov
Link(s) to related issue(s)