Skip to content

Comments

[DQT] Add "Select All" option to Default Visits dropdown#10346

Open
arnav-makkar wants to merge 5 commits intoaces:mainfrom
arnav-makkar:feature/9828-select-all
Open

[DQT] Add "Select All" option to Default Visits dropdown#10346
arnav-makkar wants to merge 5 commits intoaces:mainfrom
arnav-makkar:feature/9828-select-all

Conversation

@arnav-makkar
Copy link
Contributor

Brief summary of changes

Added the "Select All" option as requested.
I can add the "Remove All" option as well however it'll be quite redundant in my opinion.

Screen.Recording.2026-02-07.at.16.37.56.mov

Link(s) to related issue(s)

@github-actions github-actions bot added the Module: dataquery PR or issue related to (new) dataquery module label Feb 7, 2026
@marandmart
Copy link
Contributor

Brief summary of changes

Added the "Select All" option as requested. I can add the "Remove All" option as well however it'll be quite redundant in my opinion.

Screen.Recording.2026-02-07.at.16.37.56.mov

Link(s) to related issue(s)

Agree the Remove All would be redundant since clicking the x on the Select component already does exactly that. I would just make the suggestion to place the Select All option in the top rather than the bottom because depending on the size of the list that option might be hidden behind the need to scroll down the list and I think it should be seen as soon the user opens it up.

@arnav-makkar
Copy link
Contributor Author

arnav-makkar commented Feb 17, 2026

Thank you for the feedback. I have changed the logic to incorporate your suggestion. Please let me know if anything else is required.

Screen.Recording.2026-02-18.at.01.20.02.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module: dataquery PR or issue related to (new) dataquery module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DQT] - You should be able to select all the visits

2 participants