chore: bump MSRV to Rust 1.95 and adopt new stable features#91
chore: bump MSRV to Rust 1.95 and adopt new stable features#91acgetchell merged 2 commits intomainfrom
Conversation
Closes #67 - Bump rust-version to 1.95 in Cargo.toml - Bump channel to 1.95.0 in rust-toolchain.toml - Add core::hint::cold_path() hints at cold/error branches: - src/exact.rs: validate_finite, validate_finite_vec, gauss_solve singular return, det_exact_f64 / solve_exact_f64 overflow returns, det_sign_exact Stage 2 Bareiss fallback - src/lu.rs: Lu::factor and Lu::solve_vec NonFinite / Singular returns - src/ldlt.rs: Ldlt::factor and Ldlt::solve_vec NonFinite / Singular returns - src/matrix.rs: det_direct D >= 5 fallback arm (legal because cold_path is const fn in 1.95) and det NonFinite / overflow scan - Refactor det_sign_exact Stage 1 fast filter to use match + if let guard with let-chain, replacing the tuple destructure; semantics unchanged Test results (local `just ci`): - cargo fmt --all -- --check: clean - cargo clippy --workspace --all-targets --all-features -D warnings -W clippy::pedantic -W clippy::nursery -W clippy::cargo: clean - cargo test --features exact --lib: 258 passed, 0 failed - cargo test --features exact (doctests + examples): 31 passed, 0 failed - RUSTDOCFLAGS='-D warnings' cargo doc --no-deps --features exact: clean - python tests: 101 passed Co-Authored-By: Oz <oz-agent@warp.dev>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 38 minutes and 59 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughBumped minimum Rust version from 1.94 to 1.95 across toolchain configuration. Added Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related issues
Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
- Coverage 90.26% 88.58% -1.68%
==========================================
Files 5 5
Lines 452 482 +30
==========================================
+ Hits 408 427 +19
- Misses 44 55 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add test cases to verify that LDLT and LU solvers, as well as determinant calculations, correctly detect and return `LaError::NonFinite` when intermediate calculations overflow to infinity despite having finite inputs. Refs: #67
Closes #67
Test results (local
just ci):Summary by CodeRabbit
Chores