fix/2025-07-23-remove-duplicate-tests

[ackkerman]

Summary

• remove outdated CLI tests checking git remote behaviour
• clean up unused helper functions

Testing

• cargo test --all --quiet

---

https://chatgpt.com/codex/tasks/task_e_6880b30ccc1883309c4390334d1728e9

[gemini-code-assist]

Summary of Changes

Hello @ackkerman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the gh-sync CLI test suite by removing tests that are no longer necessary or relevant, specifically those that simulated various git remote interaction scenarios. Concurrently, it cleans up the associated helper functions, resulting in a more concise and efficient testing codebase.

Highlights

• Test Suite Refinement: Removed three outdated CLI tests (connect_fails_on_git_config_error, connect_updates_remote_url, connect_adds_remote_when_missing) that simulated specific git remote behaviors. These tests were no longer relevant for the current state of the gh-sync CLI.
• Code Cleanup: Eliminated three unused helper functions (fake_git_remote_missing, fake_git_remote_mismatch, fake_git_fail_config) from tests/cli.rs. These functions were exclusively used by the tests that have now been removed, contributing to a cleaner and more maintainable test suite.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request cleans up the test suite by removing three outdated and incorrect CLI tests related to git remote operations, along with their associated helper functions. The change is clean and achieves its stated goal. My review focuses on the implication of removing these tests, specifically the reduction in test coverage for certain code paths in the connect command logic. I've raised a medium-severity concern suggesting that fixing the tests might be preferable to removing them to maintain confidence in the application's behavior.