Store result ids on ImportResult (postgres only)#191
Closed
saulm wants to merge 2 commits intoactiveadmin-plugins:masterfrom
Closed
Store result ids on ImportResult (postgres only)#191saulm wants to merge 2 commits intoactiveadmin-plugins:masterfrom
saulm wants to merge 2 commits intoactiveadmin-plugins:masterfrom
Conversation
Fivell
added a commit
that referenced
this pull request
Apr 8, 2026
Adds a :result_class option to active_admin_import so users can plug in their own ImportResult subclass to collect adapter-specific data (like inserted ids) without forcing the gem to take on cross-adapter quirks. The DSL action block now receives result, options via instance_exec (matching DEFAULT_RESULT_PROC's signature) so the captured data is actually reachable from user code. Existing zero-arity blocks are unaffected since Ruby blocks ignore extra arguments. A PG-only spec demonstrates the canonical PR #191 use case (capturing result.ids), which is reliable on PostgreSQL via RETURNING but not on MySQL/SQLite without extra setup.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking for a solution to #179
Luckily I'm using postgres, and activerecord-import stores the ids for postgres: https://github.com/zdennis/activerecord-import#return-info
I understand this is not the ideal solution for everyone, but it's consistent with the behavior of the underlying base library.
Let me know if this is something you would like to add or if you need any other changes.