Remove bench result JSONs, add to gitignore#31
Closed
kaghni wants to merge 3 commits intosasun-improvefrom
Closed
Conversation
Bench JSON outputs are test artifacts (1MB), shouldn't be tracked. Added bench/*.json to .gitignore. Kept bench/run.mjs (benchmark runner). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Benchmark tooling doesn't belong in the plugin repo. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
/claude-review |
|
Claude finished @vlad-activeloop's task in 54s —— View job Review
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Comment on lines
+33
to
+36
| steps: | ||
| - name: cleanup workflow runs | ||
| uses: mattraks/delete-workflow-runs@v2.1.0 | ||
| with: |
There was a problem hiding this comment.
retain_days: 0 + keep_minimum_runs: 0 deletes all workflow history for this action on every run, including potentially the run currently in progress — you'll lose all CI audit trail for Claude reviews.
Consider keeping at least a few runs for debugging:
Suggested change
| steps: | |
| - name: cleanup workflow runs | |
| uses: mattraks/delete-workflow-runs@v2.1.0 | |
| with: | |
| retain_days: 30 | |
| keep_minimum_runs: 5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bench/*.jsonto.gitignorebench/run.mjs(benchmark runner script)🤖 Generated with Claude Code