Added structs for FieldValue, Via and added support for ticket_fields.json #6
Open
itsrainy wants to merge 6 commits intoadamar:masterfrom
Open
Added structs for FieldValue, Via and added support for ticket_fields.json #6itsrainy wants to merge 6 commits intoadamar:masterfrom
itsrainy wants to merge 6 commits intoadamar:masterfrom
Conversation
Added support for the `ticket_fields` endpoint
Author
|
I merged #7 into Hudl's master branch and it seems like that pulled those commits into this PR as well. So I'm going to close that PR and just have this one count for both sets of changes. |
itsrainy
changed the title
added 3 commits
July 22, 2015 14:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working with the
Custom_Fields,Fields, andViaticket properties was very cumbersome when they were justinterface{}types. I gave them their own types matching the documentation found hereRegarding the
Via.Sourceobject, theFromandToobjects seem to have different properties depending on thechannel. I considered making thefromandtostructs contain all the possible values, then leaving it on the user to determine which fields should/shouldn't be empty for a given channel. Thoughts on doing that?I tried to follow the style of the rest of the project. Let me know if you take issue with anything or would like anything changed.