fix: overlay and content swapped on container elements#155
Open
x401om wants to merge 1 commit intofeature/ui_builder_5_mvpfrom
Open
fix: overlay and content swapped on container elements#155x401om wants to merge 1 commit intofeature/ui_builder_5_mvpfrom
x401om wants to merge 1 commit intofeature/ui_builder_5_mvpfrom
Conversation
Two bugs fixed: 1. Schema.Element.Properties: `background` was decoded from the `.overlay` key instead of `.background`, making the background property completely non-functional. 2. Schema.Element planElement: for container elements (stack, button, box, row, column, section, pager), overlay/background were planned after content. Since the task stack is LIFO, this caused overlay results to land below content results on the result stack. During build, buildElementProperties popped content (expecting overlay) and buildBox/buildStack/etc popped overlay (expecting content), swapping them. Fix: plan overlay/background before content.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
backgrounddecoded from wrong key:Schema.Element.Propertiesdecodedbackgroundoverlays from.overlaykey instead of.background, making thebackgroundproperty completely non-functionalRoot cause
In
planElement, content was planned beforeplanElementProperties(overlay/background). Since tasks are processed LIFO, overlay was built first (result at bottom of result stack), then content (result on top). DuringbuildElement,buildElementPropertiespopped from the top — getting content instead of overlay — andbuildBox/etc. popped next — getting overlay instead of content.Fix
Schema.Element.Properties.swift:146— changed.overlay→.backgroundfor thebackgrounddecoding keySchema.Element.swift:61-88— swapped planning order:planElementPropertiesnow comes beforeplanBox/planStack/etc. for all 7 container element typesTest plan
backgroundproperty works (renders behind the element)library/elements/overlay_badges.bundlein the Gallery app🤖 Generated with Claude Code