fix(compliance): measurement_terms_rejected — shared idempotency alias + Q3 2026 dates#4220
Draft
fix(compliance): measurement_terms_rejected — shared idempotency alias + Q3 2026 dates#4220
Conversation
…s + Q3 2026 dates Hardcoded idempotency_key literals combined with runner-substituted dates (stale May 2026 window) caused IDEMPOTENCY_CONFLICT on every re-run. Both create_media_buy steps now share a single $generate:uuid_v4# alias so the scenario correctly tests that TERMS_REJECTED responses do not cache the idempotency key. Flight dates advanced to Q3 2026 to prevent stale-date runner substitution. Refs #4219
- Both steps share $generate:uuid_v4#media_buy_seller_measurement_terms_rejected_reject_terms_create_media_buy_aggressive_terms
following the established {scenario}_{phase}_{step} convention (same alias on
both = same UUID within a run, testing TERMS_REJECTED non-caching per spec)
- Add reviewer_check on accept_terms step surfacing the errored-request-releases-key
dependency (mirrors pattern from idempotency.yaml key_reuse_conflict)
- measurement_window: c30 → c28 (clearly non-standard probe value; c30 is not a
Nielsen or IAB standard window and could be confused with downloads_30d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4219
Summary
measurement_terms_rejected.yamlhad hardcodedidempotency_keyliterals (measurement-terms-probe-aggressive-v1/measurement-terms-probe-relaxed-v1) combined with a now-stale May 2026 flight window. A spec-compliant runner substitutes fresh dates whenstart_timeis past — so each re-run sent the same key with a different body, tripping the seller's mandatoryIDEMPOTENCY_CONFLICTcheck.Changes:
create_media_buysteps now use$generate:uuid_v4#media_buy_seller_measurement_terms_rejected_reject_terms_create_media_buy_aggressive_terms(the established alias pattern). Both steps intentionally share the same alias so the runner resolves them to the same UUID within a run — correctly testing thatTERMS_REJECTEDdoes not cache the idempotency key (spec rule 3: only successful responses cache).2026-07-01→2026-09-30).measurement_window: "c30"→"c28"(clearly non-standard probe value;c30is not a Nielsen/IAB standard window and could be confused withdownloads_30d).reviewer_checksentry added tocreate_media_buy_relaxed_termssurfacing the TERMS_REJECTED non-caching dependency (mirrors pattern fromidempotency.yamlkey_reuse_conflictstep).Non-breaking justification
Storyboard fixture change only — no JSON schema, task definition, or API reference is modified. Conformance harness changes are always non-breaking per playbook (existing consumers unaffected).
Pre-PR review
Two expert instances disagreed on style; I've hit the review-iteration cap and am flagging rather than resolving:
Q1 — Shared-alias naming when two steps share the same UUID:
reject_terms_create_media_buy_aggressive_terms) for the shared alias is correct and consistent with the codebase grep pattern.accept_termsstep carrying an alias that names thereject_termsstep could cause log misattribution; use a neutral name (e.g.media_buy_seller_measurement_terms_rejected_probe) instead, or the relaxed step's own coordinates (accept_terms_create_media_buy_relaxed_terms).Q2 —
measurement_window: "c28"probe value:c28orvendor_custom_windowas a clearly non-standard replacement forc30.c28is not grounded in the narrative context and the change "breaks the rejection rationale."c28, revert toc30, or use a clearly annotated non-standard label likevendor_custom_window.Session: https://claude.ai/code/session_018doLSLKHN2Aer5yHSCpeW3
Generated by Claude Code