fix(member-profile): hoist parsed URL variable outside try block#4259
Draft
fix(member-profile): hoist parsed URL variable outside try block#4259
Conversation
Fixes ReferenceError: parsed is not defined thrown on page load when an org has an existing photo URL. const inside try{} is block-scoped and inaccessible after the block ends; hoisting to let before the try resolves the scope error.
Closes #4257
https://claude.ai/code/session_01NtURTgGU62uABeHEP9hgQ7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4257
The member profile edit page threw
ReferenceError: parsed is not definedon every page load for org members who already have a photo URL saved. Theparsedvariable was declared withconstinside thetry {}block (block-scoped, not visible outside), then referenced after the block atimg.src = parsed.href. Hoisting tolet parsed;before thetryresolves the scope error.Non-breaking justification: This is a single-variable scope declaration change in client-side UI JavaScript. No API, schema, or protocol surface is touched. Existing orgs without a photo URL are unaffected; orgs with a photo URL now load the page correctly instead of crashing.
Pre-PR review:
parsed.hrefis reached), no security concernsSession: https://claude.ai/code/session_01NtURTgGU62uABeHEP9hgQ7
Generated by Claude Code