Skip to content

fix(dashboard): remove unfiltered storyboard fallback on probe failure #4262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bokelley wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(dashboard): remove unfiltered storyboard fallback on probe failure #4262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changeset/fix-storyboard-probe-fallback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
---

Fix storyboard probe-failure fallback in dashboard agent Test view: remove unfiltered /api/storyboards fallback that was showing all storyboards when capability discovery failed; replace with actionable per-reason guidance and handle specialism_parent_protocol_missing and 504 cases explicitly.
52 changes: 26 additions & 26 deletions server/public/dashboard-agents.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2965,35 +2965,35 @@ <h1>Agents</h1>
return;
}

const reasonText = errBody.reason ? ' (' + errBody.reason + ')' : '';
const msg = errBody.error || ('HTTP ' + res.status);
let html = '<div style="padding:var(--space-3);background:var(--color-error-50);border:1px solid var(--color-error-200);border-radius:var(--radius-md);color:var(--color-error-700);font-size:var(--text-sm);margin-bottom:var(--space-3);">';
html += '<strong>Could not probe agent capabilities.</strong> ' + escapeHtml(String(msg) + reasonText);
html += '</div>';

try {
const fallback = await fetch('/api/storyboards', { credentials: 'include' });
if (fallback.ok) {
const fdata = await fallback.json();
if (fdata.storyboards && fdata.storyboards.length > 0) {
html += '<div style="font-size:var(--text-xs);color:var(--color-text-secondary);margin-bottom:var(--space-2);">Showing all available storyboards:</div>';
html += '<div class="storyboard-picker">';
for (const sb of fdata.storyboards) {
html += '<div class="storyboard-picker-item" data-storyboard-id="' + escapeHtml(sb.id) + '" data-agent-url="' + escapeHtml(agentUrl) + '" data-card-id="' + escapeHtml(cardId) + '">';
html += '<div>';
html += '<div class="storyboard-picker-title">' + escapeHtml(sb.title) + '</div>';
html += '<div class="storyboard-picker-summary">' + escapeHtml(sb.summary) + '</div>';
html += '</div>';
html += '<span style="font-size:var(--text-xs);color:var(--color-text-tertiary);">' + sb.step_count + ' steps</span>';
html += '</div>';
}
html += '</div>';
}
if (errBody.specialism_parent_protocol_missing) {
let html = '<div style="padding:var(--space-3);background:var(--color-error-50);border:1px solid var(--color-error-200);border-radius:var(--radius-md);color:var(--color-error-700);font-size:var(--text-sm);">';
html += '<strong>Capabilities misconfigured.</strong>';
if (errBody.specialism && errBody.parent_protocol) {
html += ' Specialism <code>' + escapeHtml(String(errBody.specialism)) + '</code> requires <code>' + escapeHtml(String(errBody.parent_protocol)) + '</code> in <code>supported_protocols</code>.';
html += '<div style="margin-top:var(--space-2);">Add <code>' + escapeHtml(String(errBody.parent_protocol)) + '</code> to <code>supported_protocols</code> in your <code>get_adcp_capabilities</code> response.</div>';
} else {
html += ' ' + escapeHtml(String(errBody.error || 'A declared specialism is missing its required parent protocol.'));
}
} catch (fallbackErr) {
console.error('Storyboard fallback failed:', fallbackErr);
html += '</div>';
panel.innerHTML = html;
return;
}

const reasonHints = {
network: 'Check the agent URL — the host is unreachable or DNS lookup failed.',
tls: "The agent's TLS certificate is invalid or expired.",
timeout: 'The agent did not respond in time. It may be down or slow to start.',
protocol: 'The agent responded but did not speak MCP correctly.',
};
const msg = errBody.error || ('HTTP ' + res.status);
const hint = res.status === 504
? reasonHints.timeout
: (reasonHints[errBody.reason] || 'Verify the agent URL is correct and the agent is running.');
let html = '<div style="padding:var(--space-3);background:var(--color-error-50);border:1px solid var(--color-error-200);border-radius:var(--radius-md);color:var(--color-error-700);font-size:var(--text-sm);">';
html += '<strong>Could not probe agent capabilities.</strong>';
html += '<div style="margin-top:var(--space-1);">' + escapeHtml(String(msg)) + '</div>';
html += '<div style="margin-top:var(--space-2);color:var(--color-error-600);">' + escapeHtml(hint) + '</div>';
html += '</div>';
panel.innerHTML = html;
} catch (err) {
console.error('Failed to load storyboards:', err);
Expand Down
Loading