Conversation
…-webhook, auth-scheme, call-adcp-agent SKILL.md Description-only fixes closing the on-ramp framing gap identified in #4270. reporting-webhook.json called HMAC-SHA256 "recommended for production"; auth-scheme.json had no deprecation signal. Both now align with push-notification-config.json's framing. call-adcp-agent/SKILL.md gains a "Webhook signing" section so buyer agents learn to omit authentication (selecting RFC 9421 default) rather than reaching for the visible legacy field. No wire format changes; authentication remains required in 3.x per the existing schema. The optionality change (making authentication optional + defining 9421 default on reporting-webhook) is a signing-profile change routed to 3.1.x — see #4270. https://claude.ai/code/session_01WczUEAGjbrADfTVX2MWEn6
This was referenced May 8, 2026
Same description-only fix applied to artifact_webhook in create-media-buy-request.json — drops "recommended for production" on HMAC-SHA256, labels the authentication block as legacy, points new integrations at the RFC 9421 webhook signing profile. Mirrors the push-notification-config.json and reporting-webhook.json framing. Closes the last on-ramp surface from #4270.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4270
Summary
Closes the on-ramp framing gap identified in #4270 — surface 4 of the HMAC→RFC 9421 migration checklist (@bokelley's four-surface plan from #4205):
reporting-webhook.json:authentication.schemesdescription called HMAC-SHA256 "recommended for production" andauthenticationdescription had no deprecation signal. Fixed to matchpush-notification-config.jsonframing: both schemes are deprecated, RFC 9421 is the preferred profile. Sinceauthenticationremains inrequired[]in 3.x, the description now says explicitly "This field is required in AdCP 3.x; the requirement is removed in AdCP 4.0."auth-scheme.json: Enum description was silent on deprecation. Updated to label both values as legacy, note that RFC 9421 is the default when authentication is optional, and that both are removed in 4.0.skills/call-adcp-agent/SKILL.md: Added "Webhook signing — omitauthenticationfor new integrations" section under "Non-obvious rules every buyer must follow." Closes the silent-default trap: a buyer agent reading only the SKILL.md previously had no guidance that omittingauthenticationselects the RFC 9421 default; reaching for the visible field in the schema would opt the seller into the deprecated HMAC path.Non-breaking justification
Description-only changes. No field added or removed, no
requiredarrays changed, no enum values added or removed, no wire behavior change.authenticationremains required inreporting-webhook.jsonin 3.x — the schema structure is unchanged. Changeset:patch.What is NOT in this PR (flagged for human review)
Two items from #4270 require human/WG decisions before landing:
Making
authenticationoptional inreporting-webhook.json— removing fromrequired[]is a signing-profile change (playbook: "never patch-eligible: signing profile changes"). Needsminorbump and security doc update to explicitly coverreporting_webhooksigning-mode selection. Routed to3.1.x. The open question (per protocol-expert review): does thewebhook_mode_mismatchdowngrade-resistance rule already apply to reporting webhook registrations, or does the security doc need to be extended?artifact_webhookincreate-media-buy-request.json— protocol-expert found the same stale "recommended for production" framing on theauthentication.schemesdescription there. Not in scope of this PR to keep the change bounded; should be a follow-up.Pre-PR review
adagents.json→brand.jsoncorrected per security.mdx §webhook-callbacks); two nits noted (link wraps across two lines in SKILL.md, changeset description updated)brand.jsonis correct for buyer JWKS discovery (security.mdx line 1176, 1201-1206);authenticationrequired constraint intact; changesetpatchcorrectMilestone note:
ghCLI unavailable in this run environment — could not confirm the open 3.0.x patch milestone. Please set milestone to the active patch target before merge.Session: https://claude.ai/code/session_01WczUEAGjbrADfTVX2MWEn6
Generated by Claude Code