feat(member-tools): nudge publisher/adtech org admins to populate brand.json properties#4284
Draft
feat(member-tools): nudge publisher/adtech org admins to populate brand.json properties#4284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4280
Summary
Adds a setup-alert nudge to the member dashboard for publisher and adtech org admins whose
brand.jsonhas zero properties. Empty properties create downstream discovery gaps:brand.json→ property catalog →ad-agents.jsondelegation all depend on this data being populated.The nudge appears when all of:
org.roleofadminorownerorg.billing.company_typeispublisheroradtechprofile.primary_brand_domainis set (brand-mapped)profile.resolved_brand.property_countis 0 or undefinedDismissing snoozes for 7 days via
localStorage(keyed per org ID), after which it resurfaces if properties are still empty. This differs from the session-onlysessionStoragedismissal used by the other setup alerts, which are either self-resolving (publish profile, add logo) or action-gated (pending join requests). TheCSS.escape()fix on the existingquerySelectorindismissSetupAlertis a pre-existing unsafe pattern corrected in this PR.Non-breaking justification: adds a new client-side conditional branch in
dashboard.html; no API changes, no schema changes, no existing behaviour altered.Pre-PR review:
isAdminscope →org.role, snooze key mismatch → resolved withcurrentOrg?.idinvariant,CSS.escapeadded)org.rolegate correct for per-org admin checkSession: https://claude.ai/code/session_01BYkdrK3XyCwvkc6XAmLz74
Generated by Claude Code