Conversation
…4035) Three things in AdCP share the word "scenarios" and they aren't the same. External implementers grepping `node_modules/@adcp/sdk/dist/lib/testing/ scenarios/media-buy.js` for `buying_mode` and concluding sales-guaranteed coverage is missing the proposal/refine/finalize lifecycle have a reasonable evidence path — but the conclusion is wrong, because the YAML storyboards do cover that lifecycle (`proposal_finalize`, `refine_ products`). The scenario file just predates `comply()` and is no longer the source of truth. New page `docs/building/verification/storyboards-vs-scenarios.mdx` names the three things explicitly: 1. **Storyboards** (YAML at `/compliance/{version}/...`, run via `comply()`) — the conformance specification. Normative. 2. **`comply_test_controller` scenarios** (`force_*`, `simulate_*`, `seed_*` operations the seller exposes) — protocol-level tool operations that storyboards use to drive deterministic state. Normative, but different from storyboards. 3. **`@adcp/sdk/testing/scenarios/*.ts`** — legacy TypeScript test runners predating storyboard-driven `comply()`. Non-normative. May differ from storyboard contents. Plus a three-line decoder: "if you see a `.yaml` under `/compliance/...`, trust as spec; if you see a `.ts` under `testing/scenarios/`, don't." Cross-linked from `conformance.mdx` and `validate-your-agent.mdx` via `<Note>` callouts pointing readers at the disambiguation page when they might be tempted to read the legacy scenarios as the spec. Out of scope (lives in `adcp-client` repo): marking the legacy `testing/scenarios/*` exports `@deprecated`, mirroring the storyboard CLI verbs, or removing the export entirely. The packaging decision is tracked in #4035; this PR ships the docs half. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the docs half of #4035. Three things in AdCP share the word "scenarios" and they aren't the same; external implementers grep
node_modules/@adcp/sdk/dist/lib/testing/scenarios/*.jsand conclude things about AdCP that aren't true (e.g. "sales-guaranteed doesn't cover proposal-finalize" — wrong, the YAML storyboard does).What changed
docs/building/verification/storyboards-vs-scenarios.mdx<Note>callouts added toconformance.mdxandvalidate-your-agent.mdxso readers grepping legacy scenarios get redirected to storyboardsbuilding/verificationgroup locationsThe disambiguation
comply(). The conformance spec.comply_test_controllerscenariosforce_*,simulate_*,seed_*)@adcp/sdk/testing/scenarios/*.tscomply()Plus a three-line decoder ("if you see a
.yamlunder/compliance/..., trust as spec; if you see a.tsundertesting/scenarios/, don't").Out of scope (filed in #4035 for
adcp-client)@deprecatedJSDoc ontesting/scenarios/*exportsscenarios show <id>if scenarios stay public)testing/scenarios/*becomes internal-onlyStack note
Push A item 3 of 4 in the compliance reporting fidelity initiative.
verdict_sourceis in the API per-owner-scope.🤖 Generated with Claude Code