fix: Only set SESSION_COOKIE_DOMAIN in multi-tenant mode #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes login issues in single-tenant deployments where session cookies were being rejected due to domain mismatch. In single-tenant mode (ADCP_MULTI_TENANT=false), Flask should use the actual request domain for session cookies rather than a hardcoded multi-tenant domain. This affects all single-tenant deployments including Fly.io, Cloud Run, and Docker deployments. Fixes authentication for single-tenant publishers deploying their own sales agent instances.
Contributor
Author
|
Superseded by #886 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Login fails in single-tenant deployments (Fly.io, Cloud Run, Docker) because session cookies are rejected due to domain mismatch.
Root Cause
src/admin/app.py:122always setsSESSION_COOKIE_DOMAINto a hardcoded multi-tenant domain (.sales-agent.scope3.com), even whenADCP_MULTI_TENANT=false.In single-tenant mode, Flask should use the actual request domain for session cookies instead of a hardcoded domain.
Fix
SESSION_COOKIE_DOMAINwhenADCP_MULTI_TENANT=trueImpact
Testing
ADCP_MULTI_TENANT=false(default)/loginwithADCP_AUTH_TEST_MODE=trueRelated to #885 (nginx configuration issue for single-machine deployments)