Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of this PR
Add Windows and macOS to the CI build matrix. Currently the workflow only runs on Ubuntu.
Expected results
Build and tests pass on all three operating systems (Ubuntu, Windows, macOS).
Actual results
Running the workflow on Windows and macOS without fixes produces the following errors:
Windows: The debug step uses
pwd && ls -l. On Windows,lsmaps to PowerShell'sGet-ChildItem, and-lis interpreted as-LiteralPath, which requires an argument.macOS:
FontTest.testFontStyleOfStyledFontloadsCourier.ttcand expects an OS/2 TrueType table. On macOS, the bundled Courier font does not include that table. This is a platform-specific font difference, not a code defect.Description of fix
ubuntu-latest,windows-latest,macos-latest).shell: bashto the debug step so it runs correctly on Windows.Assumptions.assumeFalseto skiptestFontStyleOfStyledFonton macOS where the required font table is unavailable. An alternative approach would be to comment out or remove theFontFactory.registerDirectories()call.