skill custom config#33
Merged
Merged
Conversation
Eliminates nested ifology by extracting _require_non_empty_str, _parse_config_field_default, _parse_config_field_possible_values, and _parse_config_field_entry. Same validation behavior, flat structure. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add dict[str, Any] type args and wrap long signatures/conditions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- clipboard.py: split long subprocess command list across lines (E501) - test_parser.py: extract long match string to variable (E501) - translate/skill.py: add missing newline at EOF (W292) - translate/test_translate.py: remove unused pytest import (F401), add missing newline at EOF (W292) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ntation The implementation was migrated from plyer to subprocess (xclip/pbpaste/ powershell), but the tests still patched sys.modules["plyer"]. Updated all 10 tests to patch subprocess.run/Popen and platform guards instead. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ests Long patch target strings pushed lines past 88 chars. Extracted as module-level constants (_RUN, _POPEN, _IS_LINUX, etc.) and switched to parenthesized with-statement syntax. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.