Patch Traversal guard Wayland set-up#37
Merged
Merged
Conversation
Ambiguous parameter name allowed skill authors to accidentally pass user-controlled data into the system role. Explicit name makes the security boundary clear at the call site.
validate_skill_paths only checked existence, not confinement. A skill config with ../relative/path could reference files outside the repo root. Now resolves and asserts relative_to(base_root), matching parser.py.
… fix pipe leak in tests
Allow register() to be called after start() by acquiring _lock instead of raising RuntimeError, and snapshot _hotkeys under _lock in _run_loop to prevent dictionary-changed-size errors during concurrent iteration.
On Wayland+XWayland sessions (both WAYLAND_DISPLAY and DISPLAY set), route to X11HotkeyAdapter instead of EvdevAdapter so the daemon starts without requiring input group membership. EvdevAdapter is now only selected for pure Wayland (no DISPLAY) and headless sessions. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- _load_dotenv() reads KEY=VALUE pairs from .env at daemon startup, making them available to skill workers via inherited os.environ - Existing env vars are never overridden (.env provides defaults only) - anthropic and openai added as core dependencies so skills can use tools.ai without declaring them in manifest.yaml Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… fixes Resolved conflicts: keep anthropic+openai deps alongside evdev; fix ai.py to use correct system_prompt variable (was broken as prompt in HEAD). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.