Skip to content

added comment for clarity, no reuse of var #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
purplecabbage merged 3 commits into from
May 27, 2025
Merged

added comment for clarity, no reuse of var #150

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6fce0b9
added comment for clarity, no reuse of var
purplecabbage May 14, 2025
b6e59a3
Merge branch 'main' into nit-noreuse
purplecabbage May 21, 2025
067e0a3
Merge branch 'main' into nit-noreuse
purplecabbage May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/lib/run-dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,10 @@ async function runDev (runOptions, config, _inprocHookRunner) {

let actionUrls = {}
if (hasBackend) {
actionUrls = rtLib.utils.getActionUrls(devConfig, true /* isRemoteDev */, false /* isLocalDev */, false /* legacy */)
actionUrls = Object.entries(actionUrls).reduce((acc, [key, value]) => {
// note: 3rd arg, _isLocalDev is not used in RuntimeLib
// there is no such thing as --local anymore
const tempActionUrls = rtLib.utils.getActionUrls(devConfig, true /* isRemoteDev */, false /* isLocalDev */, false /* legacy */)
actionUrls = Object.entries(tempActionUrls).reduce((acc, [key, value]) => {
const url = new URL(value)
url.port = serverPort
url.hostname = SERVER_HOST
Expand Down