restore process.env after exec action with side-effects

[purplecabbage]

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[Copilot]

Pull Request Overview

This pull request addresses the side effects caused by running an action by ensuring that process.env and the current working directory are restored after the action executes.

• Captures process.env before any changes by cloning it.
• Stores the original working directory to restore it later.
• Restores both process.env and cwd after the action function is executed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bfd5622) to head (4d6bd5e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##              main      #153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          642       647    +5     
  Branches       132       132           
=========================================
+ Hits           642       647    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[shazron]

good idea from Copilot about the try-finally block

[Copilot]

Pull Request Overview

This PR ensures that any modifications to the process environment and working directory during action invocation are reverted afterward to prevent side-effects.

• Snapshot process.env and cwd before running the action
• Wrap action execution in try/finally to restore environment and directory
• Added comments to clarify restore logic

Comments suppressed due to low confidence (1)

src/lib/run-dev.js:355

• [nitpick] The variable name preCallEnv is ambiguous; consider renaming it to originalEnvSnapshot or envBackup for clarity.

const preCallEnv = cloneDeep(process.env)

[Copilot]

Pull Request Overview

This PR ensures that the environment variables and working directory are reset after executing an action that may have side-effects.

• Capture a snapshot of process.env and current working directory before action execution
• Inject an OpenWhisk‐style activation ID into process.env
• Restore process.env and CWD in a finally block after the action runs

Comments suppressed due to low confidence (1)

src/lib/run-dev.js:353

• There are no tests covering the restoration of process.env and CWD after an action; consider adding unit tests that change env vars and directory during an action and assert they are reset.

// if we run an action, we will restore the process.env after the call

[Copilot]

Reassigning process.env can break references elsewhere; instead clear the existing process.env and reassign properties, e.g. delete all keys then Object.assign(process.env, preCallEnv), to preserve the env object identity.