Skip to content

CEXT-5230: Releasing aio app db cli commands#27

Open
pdohogne-magento wants to merge 131 commits intomainfrom
epic/abdb-implementation
Open

CEXT-5230: Releasing aio app db cli commands#27
pdohogne-magento wants to merge 131 commits intomainfrom
epic/abdb-implementation

Conversation

@pdohogne-magento
Copy link
Collaborator

Description

Committing aio app db commands to main

Related Issue

CEXT-5230: Deploy CLI DB App to Staging

Motivation and Context

Release aio app db commands

How Has This Been Tested?

Unit and manual tests, see PRs #12 - #26

Screenshots (if appropriate):

image image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Simran Gulati and others added 30 commits June 25, 2025 18:54
Co-authored-by: Peter Dohogne <pdohogne@adobe.com>
feat:cext-4860 added standalone commands
Copy link
Member

@moritzraho moritzraho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleaan!!

lgtm :)
just one small comment

]

DeleteOne.args = {
Delete.args = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this take a many flag?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At Manik's request we are not including deleteMany functionality in the CLI

Copy link
Collaborator

@AjazSumaiya AjazSumaiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @pdohogne-magento , looks good

package.json Outdated
{
"name": "@adobe/aio-cli-plugin-app-storage",
"version": "1.1.0",
"version": "1.2.0-alpha.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version should be modified by an explicit release job. We will need to manage the pre version, and the dependency in a branch until we go GA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants