fix(edge): signal WebSocket auth failures with custom close codes#149
Open
chrischrischris wants to merge 2 commits into
Open
fix(edge): signal WebSocket auth failures with custom close codes#149chrischrischris wants to merge 2 commits into
chrischrischris wants to merge 2 commits into
Conversation
When the da-admin HEAD rejects a WebSocket upgrade, return 101 + an immediately-closed WebSocket with code 4401 (auth) or 4403 (forbidden) instead of an HTTP error that the browser surfaces only as opaque 1006. This lets the client distinguish token-expired from network failures and refresh its IMS token before reconnecting. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
auniverseaway
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the da-admin HEAD rejects a WebSocket upgrade, return 101 + an immediately-closed WebSocket with code 4401 (auth) or 4403 (forbidden) instead of an HTTP error that the browser surfaces only as opaque 1006. This lets the client distinguish token-expired from network failures and refresh its IMS token before reconnecting.