feat: comments#875
Closed
usman-khalid wants to merge 1 commit into
Closed
Conversation
95f0fe9 to
b98a639
Compare
Contributor
Author
|
Closing in favour of a follow-up cleaner PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for comments with live collaboration.
Should be merged with adobe/da-collab#132 which adds support for read-only users to write data to the Yjs comments map without touching the document content.
Description
srcfor image) + surrounding context as a snapshot.da/comments/<doc-id>.jsonfor external uses cases (sidekick extension on.page|reviews- future enhancement)Keyboard Shortcuts:
Related Issue
Fixes #472
Motivation and Context
Bridge the gap between doc-based (google docs, sharepoint) and DA :)
How Has This Been Tested?
Tested on localhost and:
Demo
Screen.Recording.2026-04-13.at.17.20.13.mov
Types of changes
Other Changes
da-toastcomponent thatda-list,da-sitesandda-commentscan usegenerateColorto a shared util as two places needed it now (avatar for comments, & Yjs live cursor)getCurrentUserfor reusabilityChecklist: