Msm#919
Open
ravuthu wants to merge 51 commits into
Open
Conversation
…se site to the satellite upon resume inheritance action
Previous nx2 prep updates removed hiding from HTML tag. This created FOUC because NX styles are loaded dynamically and do not block the initial render.
…#869) * make the preview dialog respect our ref pattern for DA library * updated fix
* chore(deps): update dependency @babel/core * fix: rennovate eslint9 modernization --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Chris Millar <chris@millr.org>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Also removes double-hyphen from .trash file names
The da-diff-added attribute was mistakenly left on content that was accepted.
…dobe#822) * fix: Switch to live preview proxy. Remove client side FF * fix: Switch to live preview proxy. Remove client side FF * fix: Set loading lazy before rewriting the src * Remove lockedImagesTest --------- Co-authored-by: Chris Millar <chris@millr.org>
Focal point for the block can be turned on using a "features" column in the library block sheet. Backwards compatibility for the "focal-point" column with "yes" value is kept for now. fix: 709
…obe#877) * feat: detect stale sheet/config and prevent concurrent overwrites * Add StaleCheck class to check for stale configs and sheets * Checks every 30 seconds for changes. * If changes, but nothing new locally, automatically updates local sheet. * If local and remote changes, present a dialog allowing to refresh or keep local edits. Keeping local edits will prevent auto saves and manual blue button saves. * da-title updates to support the following: * disabledText property which doubles for disabling actions * Remove paper plane if only one action available * Any sheet inside `/.da/` can no longer be previewed or published. * Lazily check for disablePublish to ensure actions show ASAP. * Move `isSending` to class property to allow showing send event for save only actions. * Created a class-level event for save action Resolves: adobe#704 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix linting * Update blocks/edit/da-title/da-title.js Co-authored-by: Usman Khalid <usman.khalid@live.ca> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Co-authored-by: Usman Khalid <usman.khalid@live.ca>
… length (adobe#900) * fix: sort editor.path matches by path prefix length, not total string length Without this fix, a short formsref URL would lose to a long UE URL even when the formsref path is more specific, causing the wrong editor to open for subfolder overrides. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * test: add getEditor tests covering editor.path prefix-match priority Adds cases for single match, most-specific-prefix wins, broader fallback, and no-match — directly covering the sort bug fixed in the prior commit. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* fix: Show if file has redirect setup in list view If a file has a redirect setup for Publish, change wording to "Redirect" and include link to redirect location. * Add test cases * Chang to past tense
* feat: Do not auto-create docs on edit nav Instead of automatically creating a doc when going to a new edit path, we now will present the user with a dialog asking what they would like to do. If they choose to not create a doc, they are navigated to the containing directory for that file. If a folder exists with the same name, they are also given the option of opening that folder. fix adobe#702 * Clear dialog on hashchange
Implement total count and max amount of items to delete allowed
Esc now cancels out of the edit too. fix adobe#345
fix adobe#19 Also delete a test file mistakenly checked in earlier.
We can start the cookie call in the same place, then await it after the doc has been downloaded. In my testing even with throttling the cookie is set and the await doesn't slow anything down. The preview cookie can be started afterwards as no one opens preview right at page load. 200-400ms gain in page load
…tes (adobe#870) * feat: nx2 + browse - Pass background element from browse block into da-sites component - Replace hardcoded hex colors with --s2-* CSS variables - Add gradient mask on background image - Set color scheme from localStorage/media query before render - Load utils.js early and hide HTML to prevent FOUC - Select LCP images based on active color scheme * fix test and package-lock * fix: Use Node.js 22 instead of non-existent version 24 * fix: Reset package-lock.json to main branch version Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
Co-authored-by: Adrian Kozma <kozma@adobe.com>
…#909) Two bugs allow IMS OAuth redirect fragments to pass through as an org name in admin API calls (e.g. /config/ccess_token=.../ or /config/ld_hash=/). 1. prose/index.js: hash.slice(2) strips '#a' instead of '#/' when the hash is '#access_token=...', writing 'ccess_token=...' into the URL. Guard with startsWith('#/') before slicing. 2. pathDetails.js: the IMS fragment guard was dead code — fullpath always starts with '/' so startsWith('old_hash') could never match. Also, 'ld_hash' (used by the IMS PKCE flow) was not covered at all. Strip the leading '/' before the prefix checks and add 'ld_hash'. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Also update collab status at load.
Use a single confirmation field instead of 2 when unpublishing and deleting > 10 items fix some test issues too
* fix: Improve unit test coverage * fix lint * Fix uncaught thrown promises in tests; misc small fixes
* feat: Improved html diffing * feat: version diff compare
…be#918) Two bugs caused the upload icon to re-appear after a real image was shown: 1. imageDrop.js replaced the FPO node by stale cursor position. With multiple concurrent uploads or collaborative edits in flight the wrong node could be targeted, leaving the real URL in place and putting the FPO back. Fix: each upload now embeds the unique upload URL as a hash fragment in the FPO src (fpo.svg#<uploadUrl>) and the replacement handler finds the node by that content rather than position. 2. prose/index.js called wsProvider.connect() on every window focus event, even when the WebSocket was already open. Each redundant connect() triggered a fresh Y.js session on the collab DO, which could discard in-flight document state. Fix: guard the call with !wsProvider.wsconnected. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
… full URLs) (adobe#917) - Reconstruct details.fullpath from sanitized pathParts (not raw hash) to strip double slashes - Guard fetchDaConfigs against empty org to avoid /config//undefined/ requests - Reject saveToDa calls where path is falsy, non-relative, or a full URL Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moved the custom select dropdown logic to nx2 and used it from there.
Related Issue
Motivation and Context
How Has This Been Tested?
Tested from localhost using nxlocal
Screenshots (if appropriate):
Types of changes
Checklist: