Skip to content

feat: configurable scriptsUrl and loadPage fn name for quick-edit#440

Open
hannessolo wants to merge 1 commit into
ewfrom
ew-script-path
Open

feat: configurable scriptsUrl and loadPage fn name for quick-edit#440
hannessolo wants to merge 1 commit into
ewfrom
ew-script-path

Conversation

@hannessolo
Copy link
Copy Markdown
Contributor

Summary

  • editorCtxFromHashState in canvas.js spreads optional scriptsUrl and loadPageFnName from site config into ctx
  • buildQuickEditInitPayload in nx-editor-wysiwyg.js forwards those fields into the config object sent to the iframe; _onIframeLoad passes them through
  • setupParentControllerListener in quick-edit.js reads both fields from e.data.init with fallbacks to the current hardcoded defaults (/scripts/scripts.js and 'loadPage')

No behaviour change for sites that don't supply either field.

Test plan

  • Verify quick-edit still works on a standard site (no config supplied — fallback path)
  • Verify quick-edit works on a site with a custom scriptsUrl passed through ctx
  • Verify quick-edit works on a site with a custom loadPageFnName passed through ctx
  • Confirm neither field appears in the iframe message when absent from ctx

🤖 Generated with Claude Code

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented May 13, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

Allows sites to override the scripts entry point URL and the exported
function name used by quick-edit in controller=parent mode. Both fields
flow from editorCtxFromHashState → buildQuickEditInitPayload → iframe
init message, with fallbacks to the previous hardcoded defaults.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant