feat: configurable scriptsUrl and loadPage fn name for quick-edit#440
Open
hannessolo wants to merge 1 commit into
Open
feat: configurable scriptsUrl and loadPage fn name for quick-edit#440hannessolo wants to merge 1 commit into
hannessolo wants to merge 1 commit into
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
Commits
|
Allows sites to override the scripts entry point URL and the exported function name used by quick-edit in controller=parent mode. Both fields flow from editorCtxFromHashState → buildQuickEditInitPayload → iframe init message, with fallbacks to the previous hardcoded defaults. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
9f5900f to
2f3868c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
editorCtxFromHashStateincanvas.jsspreads optionalscriptsUrlandloadPageFnNamefrom site config intoctxbuildQuickEditInitPayloadinnx-editor-wysiwyg.jsforwards those fields into theconfigobject sent to the iframe;_onIframeLoadpasses them throughsetupParentControllerListenerinquick-edit.jsreads both fields frome.data.initwith fallbacks to the current hardcoded defaults (/scripts/scripts.jsand'loadPage')No behaviour change for sites that don't supply either field.
Test plan
scriptsUrlpassed throughctxloadPageFnNamepassed throughctxctx🤖 Generated with Claude Code