feat: extend --html-folder to serve local JSON form definitions on-the-fly#2707
Closed
navneet-ag wants to merge 4 commits intoadobe:mainfrom
Closed
feat: extend --html-folder to serve local JSON form definitions on-the-fly#2707navneet-ag wants to merge 4 commits intoadobe:mainfrom
navneet-ag wants to merge 4 commits intoadobe:mainfrom
Conversation
…ublishing Adds --local-forms and --local-forms-mount flags to `aem up` so forms can be rendered locally from JSON files without requiring a publish step. The server constructs the standard AEM form page HTML and lets client-side scripts handle rendering. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
this use case can be covered with the |
Remove the --local-forms and --local-forms-mount flags and extend the existing --html-folder mechanism to resolve .json files on-the-fly, rendering them as AEM form block HTML via generateFormPageHtml(). Resolution priority: .html > .plain.html > .json Users migrate from: aem up --local-forms forms to: aem up --html-folder forms --html-mount /content/forms/af/ Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
navneet-ag
changed the title
tripodsan
requested changes
Apr 22, 2026
Contributor
tripodsan
left a comment
tripodsan
left a comment
There was a problem hiding this comment.
json is used to store sheets and should not be rendered differently. I don't see why the server should transform it into html
Extend the --html-folder handler to serve files with extensions (e.g. .json) as-is from the folder. This enables the anchor tag pattern for forms: an HTML page references a local JSON file via <a href>, and the form block JS fetches it at runtime. Removes the JSON-to-HTML transform (generateFormPageHtml) since the server should not perform markup-specific rendering. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Author
|
@tripodsan Agreed — removed the JSON→HTML transform completely. The server no longer renders JSON differently. The only remaining change: --html-folder now serves static files (like .json) as-is from the folder. This enables a local |
tripodsan
reviewed
Apr 27, 2026
| * @param {string} relativePath path relative to HTML folder | ||
| */ | ||
| async serveHtmlFolderStaticFile(req, res, next, relativePath) { | ||
| if (relativePath.includes('/../') || relativePath.includes('..')) { |
Contributor
There was a problem hiding this comment.
why do you need both checks ? isn't ..` sufficient?
tripodsan
approved these changes
Apr 27, 2026
Merged
Contributor
|
merge with #2717 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the existing
--html-foldermechanism to also resolve.jsonfiles,rendering them as AEM form block HTML on-the-fly without requiring a publish step.
When a request hits the html-folder handler and no
.htmlor.plain.htmlfileis found, it falls back to a
.jsonfile and callsgenerateFormPageHtml()toproduce the standard form block structure the client-side form script expects.
Resolution priority:
.html>.plain.html>.jsonUsage:
Replaces the previously proposed
--local-forms/--local-forms-mountflagsbased on reviewer feedback.
Related Issues
Thanks for contributing!