feat(content): clone HTML/JSON by default, add --media for assets#2709
Open
davidnuescheler wants to merge 2 commits intomainfrom
Open
feat(content): clone HTML/JSON by default, add --media for assets#2709davidnuescheler wants to merge 2 commits intomainfrom
davidnuescheler wants to merge 2 commits intomainfrom
Conversation
- Filter listed files to .html and .json unless --media is passed - Add filterFilesForContentClone helper in content-shared - Log when total discovered count exceeds cloned count - Extend clone command and tests Made-with: Cursor
kptdobe
previously approved these changes
Apr 20, 2026
tripodsan
requested changes
Apr 20, 2026
Contributor
tripodsan
left a comment
tripodsan
left a comment
There was a problem hiding this comment.
improve extension operation (this certainly exists already somewhere....)
| * @param {boolean} includeMedia | ||
| * @returns {typeof files} | ||
| */ | ||
| export function filterFilesForContentClone(files, includeMedia) { |
Contributor
There was a problem hiding this comment.
why is the check for media here? it just returns true, so why filter at all?
but it's ok to keep it, in case in the future there are more files to filter.
|
This PR will trigger a minor release when merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aem content clonenow downloads only.htmland.jsonfiles by default (case-insensitive).--mediato include all other file types (images, video, SVG, PDF, etc.), matching the previous all-files behavior.--media.Testing
test/content/clone.cmd.test.jsandtest/content/content-commands.test.js.Made with Cursor