feat: baseurl validation #1122
Open
feat: baseurl validation #1122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will trigger a minor release when merged. |
ekremney
requested changes
Dec 5, 2025
Member
There was a problem hiding this comment.
-
the
isValidUrlfunction is used all over the codebase. The new behavior would break many existing usecases. We need to keep the current url validation for everything outside the site baseURL flow -
Instead, introduce a new function
isValidBaseUrlwith the stricter rules you implemented. Use the new function from the data-access package, where the baseURL field is validated -
also, let's allow both
httpandhttpsfor baseURL.. not just https. -
in spacecat (unlike llmo), baseURLs can also have path like
https://adobe.com/photoshop
Thanks!
…url-validation
…url-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we validate the baseurl
Related Issues
https://jira.corp.adobe.com/browse/LLMO-790
Thanks for contributing!