-
Notifications
You must be signed in to change notification settings - Fork 111
[CLIENT-3805] Add missing app_id attribute to Cluster class for extended metrics #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
DomPeliniAerospike
wants to merge
26
commits into
dev
Choose a base branch
from
CLIENT-3805
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #864 +/- ##
==========================================
+ Coverage 83.25% 83.28% +0.03%
==========================================
Files 99 99
Lines 14348 14374 +26
==========================================
+ Hits 11946 11972 +26
Misses 2402 2402 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
juliannguyen4
requested changes
Dec 2, 2025
…control over app_id
…valid cluster_name. Fix type in docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra changes:
app_idto be set toNone.app_idandcluster_nameoption to beNone.cluster_nameoption.Docs
https://aerospike-python-client--864.org.readthedocs.build/en/864/aerospike.html#:~:text=meaning%20‘never%20compress’-,cluster_name,-(Optional[str
TODO
Manual testing
Valgrind run
Massif run
Build artifacts with tests
Code coverage is fully covered, coverage report shows missing lines because it is a standalone test.