Apricot #1660
Open
Apricot #1660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
requested changes
| public struct RgbFunctionCurve { | ||
| [FieldOffset(0x0)] public uint Data; | ||
| // not a fixed size array, not sure how else to handle this? | ||
| [FieldOffset(0x4), FixedSizeArray] internal unsafe fixed byte _keys[0x10]; |
Collaborator
There was a problem hiding this comment.
I think what you were looking for was FixedSizeArray2<Pointer<RgbKey>>.
But in this case, with a dynamic sized array, it probably won’t help much.
Collaborator
There was a problem hiding this comment.
Could do
[FieldOffset(0x4)] public RgbKey* KeyPointer;
public Span<RgbKey> Keys => new Span(KeyPointer, KeyCount);with looking at how the GetKey function works
Contributor
Author
There was a problem hiding this comment.
I think what you were looking for was
FixedSizeArray2<Pointer<RgbKey>>. But in this case, with a dynamic sized array, it probably won’t help much.
Originally tried this with a FixedSizeArray1, but it throws a IndexOutOfRangeException beyond the first element.
Could do
[FieldOffset(0x4)] public RgbKey* KeyPointer; public Span<RgbKey> Keys => new Span(KeyPointer, KeyCount);with looking at how the
GetKeyfunction works
There isn't a pointer here, it's an inline array with a dynamic size.
wolfcomp
reviewed
Dec 13, 2025
FFXIVClientStructs/FFXIV/Client/Graphics/Vfx/VfxResourceHandle.cs
Outdated
Show resolved
Hide resolved
Caraxi
reviewed
Dec 13, 2025
github-actions
bot
removed
the
requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apricot is a nice fruit