Support editing properties of type array without oneOf, selector and selectorAll#855
Merged
Merged
Conversation
vincentfretin
force-pushed
the
fix-type-array-of-string
branch
from
e12bd40 to
25b245f
Compare
… startEvents InputWidget now owns its (de)serialization (mirroring SelectWidget's pattern): it accepts value as string, array, or custom object, and when a schema is provided it stringifies non-string values via schema.stringify for display and parses the input back via schema.parse on change for array-typed properties. This ensures A-Frame always receives an array for array-type properties — avoiding arrayStringify being called on a raw string downstream (which would crash with "t.join is not a function"). The "custom string type like event-set" stringify previously done in PropertyRow is also moved here. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vincentfretin
force-pushed
the
fix-type-array-of-string
branch
from
25b245f to
f005eed
Compare
For selector and selectorAll types, read the value from getDOMAttribute (the raw selector string) rather than props.data (the parsed Element/NodeList), and commit on blur instead of on every keystroke — querying the DOM on each character is wasteful and a partial selector is rarely valid. Omit the schema when rendering InputWidget so the typed string is passed through to setAttribute as-is, which A-Frame preserves verbatim in attrValue even if it doesn't resolve. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vincentfretin
changed the title
Member
|
thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for editing a property of type array without oneOf like animation startEvents, selector and selectorAll types.
I did the same in aframe-editor c-frame#69 already released in 1.7.25