Focus contamination warn on PLC potential#62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
As reported in #60 , we're currently warning on contamination even for cases where there are only auxiliary languages. This is unnecessarily noisy; the contamination check is intended to flag application programming languages for PLC risk. There is no research to support similar concerns exist for config languages or shell.
With these changes, the contamination check should now only fire when multiple application languages are detected.
How to test
New tests in:
And a new test fixture that contains only auxiliary languages to confirm correct behavior.
Checklist
go test -race ./... -count=1)golangci-lint run)