fix: prevent AttributeError in _apply_settings when context has no agent0#1615
Open
PaoloC68 wants to merge 1 commit into
Open
fix: prevent AttributeError in _apply_settings when context has no agent0#1615PaoloC68 wants to merge 1 commit into
PaoloC68 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_apply_settingscrashes withAttributeError: 'AgentContext' object has no attribute 'agent0'in contexts whereagent0has not been initialized yet (e.g. during early startup or in lightweight contexts created for settings application before the agent loop starts).Root Cause
AgentContextdoes not guaranteeagent0is set at the point_apply_settingsis called. The attribute access raisesAttributeErrorinstead of gracefully handling the missing agent.Fix
One-line change.
getattrwith a default ofNonematches the existing null-check pattern already used downstream in the same function.Impact
agent0is present