fix(plugins): restore list defaults and remove turtle import#1620
Open
ruizanthony wants to merge 1 commit into
Open
fix(plugins): restore list defaults and remove turtle import#1620ruizanthony wants to merge 1 commit into
ruizanthony wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
from turtle import stampimport from the plugin installer helper, which imports Tkinter and breaks headless/Docker environments without_tkinter.Validation
python -m py_compile api/plugins_list.py plugins/_plugin_installer/helpers/install.py plugins/_plugin_installer/api/plugin_install.pyplugins/_plugin_installer/api/plugin_install.py.api.plugins_list.PluginsList.Context
On current
origin/main,/api/plugins_listdefaults bothcustomandbuiltintoFalse, so an empty or missing filter returns an empty plugin list. Also the plugin installer endpoint can fail on import in headless environments becauseturtleimportstkinter, which requires_tkinter.