XSS fix(webui): sanitize chat markdown rendering#1635
Merged
Conversation
Collaborator
|
Thank you! |
Author
|
Thank you for the quick actions, after the patch can a CVE be issued so older versions are tracked and indexed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Chat messages render Markdown with
marked.parse(...)and then inject the resulting HTML into the DOM. This change applies the existingsanitizeHtml(...)helper to rendered chat Markdown before path-link decoration andinnerHTMLassignment.The sanitizer keeps the default behavior unchanged for existing safe-markdown users. The chat renderer opts into the existing chat-specific rendering needs:
<latex>tag when KaTeX rendering is enabledjavascript:URLs, scripts, SVG, and other unsafe content