Skip to content

docs: add missing demo references for skyfire-kya and identity-a2a#102

Open
Sertug17 wants to merge 1 commit into
agentcommercekit:mainfrom
Sertug17:docs/add-missing-demo-references
Open

docs: add missing demo references for skyfire-kya and identity-a2a#102
Sertug17 wants to merge 1 commit into
agentcommercekit:mainfrom
Sertug17:docs/add-missing-demo-references

Conversation

@Sertug17
Copy link
Copy Markdown

@Sertug17 Sertug17 commented May 20, 2026

Summary

Two demos exist in the repository but are missing from documentation:

1. Skyfire KYA demo missing from README.md

The root README.md lists 4 demos (identity, identity-a2a, payments, e2e), but package.json and AGENTS.md both include a 5th: demo:skyfire-kya. Added the Skyfire KYA demo section to the root README.

2. Identity A2A and Skyfire KYA demos missing from demos/README.md

The demos/README.md only lists 3 demos (identity, payments, e2e), missing both identity-a2a and skyfire-kya. Added both.

Files Changed

  • README.md — Added Skyfire KYA demo section after End-to-End Demo
  • demos/README.md — Added Identity A2A and Skyfire KYA demo sections

Summary by CodeRabbit

  • Documentation
    • Updated project documentation with comprehensive demo guides
    • Added Skyfire KYA demo documentation with execution commands and source links
    • Added Identity A2A demo documentation with setup instructions and references
    • Expanded README with clear navigation to demo implementations

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d6151a14-9153-47ce-9b52-d2a12172d223

📥 Commits

Reviewing files that changed from the base of the PR and between 6f65936 and d3097a3.

📒 Files selected for processing (2)
  • README.md
  • demos/README.md

Walkthrough

This PR adds documentation for two new demos. README.md documents the Skyfire KYA demo and its integration with ACK-ID identity infrastructure. demos/README.md is expanded with entries for both Identity A2A and Skyfire KYA demos, including descriptions, run commands, and source code links.

Changes

Demo documentation

Layer / File(s) Summary
Demo documentation for Identity A2A and Skyfire KYA
README.md, demos/README.md
README.md adds a Skyfire KYA Demo subsection with purpose, command, and folder link. demos/README.md expands with Identity A2A demo (A2A-compatible agents using ACK-ID) and Skyfire KYA demo (KYA token integration), each with descriptions, pnpm commands, and code links.

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding documentation for two missing demo references (skyfire-kya and identity-a2a) in the README files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant