Fix inputRef leaking onto <input> DOM element#117
Open
DerekAgility wants to merge 1 commit into
Open
Conversation
FormInputWithAddons was passing inputRef as a prop into InputField,
which didn't destructure it — so it landed in ...rest and got spread
onto the underlying <input>, triggering a React DOM-prop warning even
when consumers never passed inputRef. Now FormInputWithAddons forwards
the ref via ref={inputRef}, and InputField defensively strips inputRef
from props so the leak can't reoccur.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FormInputWithAddonswas passinginputRefas a regular prop intoInputField.InputFielddidn't destructure it, so it ended up in...restand was spread onto the underlying<input>, producing a React DOM-prop warning (React does not recognize the inputRef prop on a DOM element) for every consumer — even when noinputRefwas passed.ref={inputRef}inFormInputWithAddons(InputField is already aforwardRef), and defensively destructuringinputRefout of props inInputFieldso a future caller spreadinginputRefcan't reintroduce the leak.TextInput,TextArea,Select,TextInputSelect,AnimatedFormInputWithAddons) — none of them leak.Test plan
yarn test --run— all 14 tests across 3 files passFormInputWithAddons.test.tsxfails onmainand passes on this branchFormInputWithAddonswith and withoutinputRefand confirm the browser console no longer logs the React warning🤖 Generated with Claude Code