Closed
Conversation
This adds a bit more ifdef zoo to be compatible with the breaking change in aeson. Tested manually against GHC 8.10.7 and GHC 9.0.2. Might want to update the CI as well, but I don’t have the time to touch CircleCI yaml.
GHC 9 warns that `*` will be removed soon. Tested against 8.10.7 and 9, might not work with some old `base` versions.
Author
|
Beware that there is a regression in the Variant tests: We are not using Variants, so I’m ignoring that for now. |
Author
|
Oh, I also think the second commit is not valid, simply replacing every leads to the error So I’m guessing it is less generic than |
Author
|
Nvm, apparently the |
Author
|
Superseded by #35 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small update I made so we can use superrecord with GHC 9 and aeson 2.
See commit messages, might not be up to standard with this project’s guidelines (e.g. CI needs to be adjusted I guess, and older GHCs might not like the Type change).