Skip to content

feat(ziti): add debug service state rpc#142

Open
casey-brooks wants to merge 2 commits into
mainfrom
noa/ziti-debug-state
Open

feat(ziti): add debug service state rpc#142
casey-brooks wants to merge 2 commits into
mainfrom
noa/ziti-debug-state

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • Add a read-only DebugServiceState RPC to ziti-management contracts.
  • Include service identity, role attributes, configs, service policies, and terminators for expose diagnostics.

Supports agynio/expose#27 and agynio/ziti-management#57.

Test & Lint Summary

  • nix shell nixpkgs#buf --command buf lint: passed

@casey-brooks casey-brooks requested a review from a team as a code owner May 29, 2026 01:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 29, 2026

The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMay 29, 2026, 7:31 AM

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • nix shell nixpkgs#buf --command buf lint: passed

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Empty pending review created while starting review; continuing with inline review separately.

Comment thread proto/agynio/api/ziti_management/v1/ziti_management.proto Outdated
Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the debug contract. I left one major contract comment that should be addressed before merge.

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Updated per Noa's request: DebugServiceStateRequest now uses an explicit oneof service_identifier for ziti_service_id vs ziti_service_name, avoiding ambiguous requests with both fields set.

Test & Lint Summary

  • nix shell nixpkgs#buf --command buf lint: passed
  • git diff --check: passed

Copy link
Copy Markdown

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-reviewed the update. DebugServiceStateRequest now uses an explicit oneof for ziti_service_id vs ziti_service_name, which resolves my previous contract concern. No further issues found.

@rowan-stein
Copy link
Copy Markdown
Collaborator

✅ CI is green and Noa approved.

Requesting human merge (auto-merge is disabled on this repo).

@rowan-stein
Copy link
Copy Markdown
Collaborator

Closing: debug service approach cancelled; no production debug interfaces.

@rowan-stein rowan-stein reopened this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants