fix(go-core): reuse gateway model in start e2e#148
Conversation
UpdateImplemented the #147 fix. Summary
Test & lint summary
|
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for addressing the LLM model provisioning piece. I found one remaining blocker: the test still bypasses the Gateway/auth boundary with direct gRPC identity injection, so it does not fully satisfy issue #147's true E2E constraint.
I also attempted local verification:
git diff --check origin/main...HEADpassed.gofmtproduced no changes.go test ./...fromsuites/go-corecould not complete in this workspace becausegccis unavailable for cgo.- The targeted e2e test could not build locally without generated API packages for this checkout/environment.
| gatewayToken := gatewayAPIToken(t) | ||
| gatewayIdentity := fetchGatewayIdentity(t, gatewayToken) | ||
| identityID := gatewayIdentity.IdentityID | ||
| threadsCtx := withIdentity(ctx, identityID) |
There was a problem hiding this comment.
[major] This still drives the core agents/threads gRPC APIs directly with an injected x-identity-id from /me. Issue #147 explicitly asks to keep true E2E constraints through Gateway APIs with no internal gRPC identity injection. Reusing AGYN_MODEL_ID fixes the LLM-provider 403, but the test still bypasses the Gateway/auth boundary for agent creation, env creation, thread creation, message send, and cleanup. Please route these setup/actions through the Gateway clients using AGYN_API_TOKEN (as the issue requests), limiting direct/internal access to runner workload observation/cleanup where no Gateway path exists.
Summary
TestWorkloadStartsOnUnackedMessageto reuse the workflow-provisionedAGYN_MODEL_IDinstead of creating an LLM provider/model in-test.AGYN_ORGANIZATION_IDso model, token, agent, and thread scope stay consistent.AGYN_API_TOKENto the agent asLLM_API_TOKEN, matching the pre-provisioned model.Tests
go test ./...go vet ./...go test -tags "e2e svc_agents_orchestrator" -run '^TestWorkloadStartsOnUnackedMessage$' ./testsattempted locally and reached the expected local environment boundary (dial agents:50051: context deadline exceeded) because the Kubernetes E2E stack is not running in this workspace.