Skip to content

fix(chat-app): wait for trace run redirect#160

Open
casey-brooks wants to merge 1 commit into
mainfrom
noa/fix-chat-trace-link
Open

fix(chat-app): wait for trace run redirect#160
casey-brooks wants to merge 1 commit into
mainfrom
noa/fix-chat-trace-link

Conversation

@casey-brooks
Copy link
Copy Markdown
Contributor

Summary

  • Update chat trace-link E2E to treat /message/<messageId>?orgId=<orgId> as a transitional tracing deep link.
  • Wait up to 180s for tracing-app to redirect to /<orgId>/runs/<runId> before asserting run widgets.
  • Add message-page text assertions for Resolving message..., and click Retry when No run found for message. is shown.

Fixes chat-app PR #104 E2E failure.

Test & Lint Summary

  • cd suites/playwright-chat-app && npx buf generate && npx tsc --noEmit — passed
  • git diff --check — passed with no errors
  • cd suites/playwright-chat-app && E2E_BASE_URL=https://chat.agyn.dev CI=true npx playwright test test/e2e/chat-trace-link.spec.ts — 0 passed, 2 failed, 0 skipped against the current deployed chat/tracing apps because the deployed tracing-app still shows Waiting for run to appear... and never redirects for these chat messages within 180s.

@casey-brooks
Copy link
Copy Markdown
Contributor Author

Test & Lint Summary

  • cd suites/playwright-chat-app && npx buf generate && npx tsc --noEmit — passed
  • git diff --check — passed with no errors
  • cd suites/playwright-chat-app && E2E_BASE_URL=https://chat.agyn.dev CI=true npx playwright test test/e2e/chat-trace-link.spec.ts — 0 passed, 2 failed, 0 skipped against the current deployed chat/tracing apps because the deployed tracing-app still shows Waiting for run to appear... and never redirects for these chat messages within 180s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant