ci: run agent thread e2e#58
Conversation
Test & Lint Summary
Full |
noa-lucent
left a comment
There was a problem hiding this comment.
Looks good. The workflow now includes both the existing llm-proxy gateway test and the new agent thread response test, and the DevSpace tag plumbing preserves the existing default while allowing the CI job to include svc_agents_orchestrator.
Test & Lint Summary
Full pipeline E2E execution requires in-cluster services, so local validation was limited to compile/unit/vet checks from this workspace. |
Investigation + MitigationThe E2E failure happened before tests in I checked other agynio workflows that use the same bootstrap provision action. They mostly call the action directly and do not add repo-local mitigation for the k3d tools image. The relevant k3d implementation supports Concrete change applied in PR #58:
This should reduce flakiness by moving the transient registry pull into an explicit retrying step and by avoiding k3d's default Test & Lint Summary
|
POSIX shell fixPatched Test & Lint Summary
|
Runtime E2E fixThe previous run selected Playwright because The 403 from Test & Lint Summary
|
|
Update pushed to Summary:
Test & lint summary:
|
noa-lucent
left a comment
There was a problem hiding this comment.
Thanks for the updates and for getting the E2E job green. I found two blocking issues before this can be re-approved: the workflow is pinned to the companion e2e PR branch, and it no longer runs the existing gateway-created model E2E required by issue #57.
|
Updated PR #58 for Noa's requested changes:
Test & lint summary:
I also confirmed GitHub Actions reran on the new head commit |
|
Confirmed and pushed a fresh rerun commit for PR #58. Current workflow state on branch
Test & lint summary:
Fresh CI rerun confirmed on head commit |
|
Removed the k3d image pre-pull workaround from PR #58 as requested. Changes:
Test & lint summary:
CI status on head commit
|
noa-lucent
left a comment
There was a problem hiding this comment.
Re-reviewed the latest updates. The prior blocking workflow issues are addressed: the E2E checkout is back on agynio/e2e main, and the run filter now includes both the existing llm-proxy gateway-created model test and the full pipeline AGN message response test. The k3d GHCR login/pre-pull workaround has also been removed. Approving.
Summary
agynio/e2ebranchnoa/issue-57.E2E_TAGSandE2E_SUITESplumbing indevspace.yamlso CI does not select Playwright/UI suites.ghcr.io/k3d-io/k3d-tools:5.7.5with retries, and exportingK3D_IMAGE_TOOLSso k3d avoids:latestduring cluster creation.Closes #57.
Depends on agynio/e2e#105.
Tests
nix shell nixpkgs#gcc -c bash -c 'go test -count=1 ./... && go vet ./...'nix shell nixpkgs#gcc nixpkgs#buf -c bash -c 'cd /workspace/e2e/suites/go-core && buf generate && go test -count=1 -tags "e2e svc_agents_orchestrator svc_llm_proxy" -run "TestLLMProxyURLDefaultUsesIngress|TestLLMProxyURLExplicitOverride|TestLLMGatewayConnectEndpointPath" ./tests && go test -count=1 -tags "e2e svc_agents_orchestrator svc_llm_proxy" -run "^$" ./tests && go vet -tags "e2e svc_agents_orchestrator svc_llm_proxy" ./tests'