Skip to content

log: show no backtrace by default #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rr0gi merged 1 commit into from
Aug 6, 2025
Merged

log: show no backtrace by default #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions log.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ let read_env_config = State.read_env_config
(**
param [lines]: whether to split multiline message as separate log lines (default [true])

param [backtrace]: whether to show backtrace (default is [true] if [exn] is given and backtrace recording is enabled)
param [backtrace]: whether to show backtrace if [exn] is given (default is [false])

param [saved_backtrace]: supply backtrace to show instead of using [Printexc.get_backtrace]
*)
Expand All @@ -163,15 +163,15 @@ let make_s output_line =
output lines facil (s ^ " : exn " ^ Exn.str exn ^ (if bt = [] then " (no backtrace)" else ""));
List.iter (fun line -> output_line facil (" " ^ line)) bt
in
fun ?exn ?(lines=true) ?backtrace ?saved_backtrace s ->
fun ?exn ?(lines=true) ?(backtrace=false) ?saved_backtrace s ->
try
match exn with
| None -> output lines facil s
| Some exn ->
match saved_backtrace with
| Some bt -> print_bt lines exn bt s
| None ->
match Option.default (Printexc.backtrace_status ()) backtrace with
match backtrace with
| true -> print_bt lines exn (Exn.get_backtrace ()) s
| false -> output lines facil (s ^ " : exn " ^ Exn.str exn)
with exn ->
Expand Down