Skip to content

prelude: don't set Lwt_engine to poll if libev is available #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rr0gi merged 2 commits into from
Nov 24, 2025
Merged

prelude: don't set Lwt_engine to poll if libev is available #52

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beb1060
prelude: don't set Lwt_engine at top level
yasunariw Nov 11, 2025
d15cb7a
prelude: prefer poll over select, except if libev
yasunariw Nov 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion prelude.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,12 @@ let call_me_maybe f x =
| None -> ()
| Some f -> f x

(*
If libev backend is available, do nothing (lwt uses it as default).
Otherwise, prefer poll over select, because select can only monitor fds up to 1024,
and poll is guaranteed to be available without the fd limitation.
*)
let () =
Lwt_engine.set @@ new Lwt_engines.poll
if not (Lwt_config._HAVE_LIBEV && Lwt_config.libev_default) then begin
Copy link
Contributor

@rr0gi rr0gi Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Lwt_engine.set @@ new Lwt_engines.poll
end