Add AIBTC Media link to homepage navigation#303
Add AIBTC Media link to homepage navigation#303andrerserrano wants to merge 2 commits intoaibtcdev:mainfrom
Conversation
- Added Media button next to Signals in datebar navigation - Links to https://aibtc.media/ - Maintains consistent styling with existing nav links
arc0btc
left a comment
There was a problem hiding this comment.
Adds a Media navigation link to the datebar nav pointing to https://aibtc.media/ — clean, single-line addition that fits the nav pattern well.
What works well:
- Correct placement (between Signals and Archive, as described)
- Consistent styling using
nav-linkclass — matches all other nav items exactly - HTTPS URL, no security concerns
[question] External link opens in same tab (public/index.html)
All other datebar links (/signals/, /archive/, /about/) are relative internal paths. https://aibtc.media/ is an external site — clicking it will navigate the user away from agent-news entirely. If that's intentional, no change needed. If you'd prefer to preserve the user's place, consider:
<a class="nav-link" href="https://aibtc.media/" target="_blank" rel="noopener noreferrer">Media</a>
The rel="noopener noreferrer" is a security best practice for external links (prevents the new tab from accessing window.opener).
Code quality notes: No reuse or complexity concerns — the change is appropriately minimal.
Operational note: We run agent-news sensors in production; this change has no API or data-path impact.
biwasxyz
left a comment
There was a problem hiding this comment.
Review: PR #303 — Add AIBTC Media link to homepage navigation
Verdict: Approve
Clean single-line addition. The link is placed consistently with the existing nav items (between Signals and Archive), uses the same nav-link class, and points to a valid external domain.
No security concerns — it's a static <a> tag with no dynamic content.
LGTM.
biwasxyz
left a comment
There was a problem hiding this comment.
Re-review: PR #303 — AIBTC Media link
Changing from approve to request changes. One issue missed in the initial review:
[blocking] External link missing target and rel attributes
<a class="nav-link" href="https://aibtc.media/">Media</a>This is the only external link in the nav bar — all other nav-link items (/signals/, /archive/, /about/) are internal. Clicking "Media" navigates the user away from the site with no way back except the browser back button.
External nav links should use:
<a class="nav-link" href="https://aibtc.media/" target="_blank" rel="noopener noreferrer">Media</a>target="_blank"— opens in a new tab, doesn't navigate away from the news siterel="noopener noreferrer"— prevents the new tab from accessingwindow.opener(security best practice for external links)
[nit] No visual indicator this is an external link
Users expect nav links to be internal. Consider adding a small external-link icon or distinguishing it visually. Not blocking, but it's confusing when one nav item silently leaves the site.
|
Confirming biwasxyz's CHANGES_REQUESTED — the fix is a single-line change in the HTML template. Both attributes are required: <a class="nav-link" href="https://aibtc.media/" target="_blank" rel="noopener noreferrer">Media</a>Once you push this, the CHANGES_REQUESTED should clear and the PR can merge (arc0btc + biwasxyz already APPROVED the concept). Happy to re-review after the push. — T-FI |
Opens external aibtc.media link in a new tab and adds rel="noopener noreferrer" for security, as requested in PR review. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Updated the Media link to include |
Code reviewNo issues found. Checked for bugs, duplicates against main, and overlap with other open PRs. Change is not yet applied in main and does not duplicate another open PR. |
@biwasxyz it looks like this still needs your approval. Since there's no issues found, could you take a look? |
|
Hey @andrerserrano — thanks for this! aibtc.media is still live and it's a useful resource. The nav bar is getting pretty full though, so we want to think about how to integrate this without cluttering the UI. A couple questions:
Would love your input before we decide on placement. |
Adds a Media navigation button next to Signals that links to https://aibtc.media/