IMP add mig duration & fix disply module of the current version #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| module_partner_ids = fields.One2many( | ||
| "module.partner", | ||
| "module_id", | ||
| ) |
Member
There was a problem hiding this comment.
Je vois que tu retires le readonly, pour ensuite rendre le one2many editable avec les champs que tu rajoutes.
Je ne suis pas sûr que ce soit souhaitable, la vue form des "module.information" pour moi devrait être consultable mais je ne pense pas qu'on veuille que les utilisateurs viennent aller modifier des trucs dedans, c'est source d'erreur.
Il y a un menu et des vues dédiées aux 'module.partner'. Pourquoi ne pas plutôt aller ajouter les champs sur ces vues ?
Je trouve cela plus logique et moins source d'erreur (d'aller modifier des modules d'autres clients..)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ping @bealdav, @florian-dacosta