Fix #61: Lower plotly_static version to 0.0.4#62
Conversation
WalkthroughDependency version for plotly_static in Cargo.toml was changed from 0.1.0 to 0.0.4. The optional flag remains true. No other dependencies, features, or public interfaces were modified. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Cargo.toml (2)
23-23: Sensible downgrade; consider making the exact pin explicit with "=".Using "0.0.4" already effectively pins to exactly 0.0.4 under Cargo’s caret rules for 0.0.x, but making it explicit clarifies intent for maintainers and dependents.
-plotly_static = { version = "0.0.4", optional = true } +plotly_static = { version = "=0.0.4", optional = true }
6-6: MSRV set to 1.86.0 looks unusually high—confirm intent.If not intentional, consider lowering to the actual tested MSRV to avoid excluding users unnecessarily. Otherwise, document why 1.86.0 is required.
You can verify current MSRV with tools like cargo-msrv or by running CI against a matrix of Rust toolchains (e.g., stable n-2..stable).
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (1)
Cargo.toml (1)
28-33: Unable to verify in CI sandbox – please confirm feature builds locallyThe sandbox environment here can’t run
cargocommands (no/proc/self/exe), so we’re relying on you to validate that all static‐export feature combinations still compile and link cleanly againstplotly_static = "0.0.4". Please run the following in your local machine or CI and share any errors:
- Pin
plotly_staticand update your lockfile:
cargo update -p plotly_static --precise 0.0.4- Base check without features:
cargo check --all-targets- Each static export combo:
for feat in static_export_chromedriver static_export_geckodriver static_export_default; do echo "==> Checking with feature: $feat" cargo check --all-targets -F "$feat" done- Inspect the feature/dependency graph:
cargo tree -e featuresIf any combination fails, please adjust the Cargo.toml or feature flags accordingly.
alceal
left a comment
There was a problem hiding this comment.
Thank you for catching this issue and providing the fix! I appreciate you explaining the context about the plotly bug and why we need to keep plotly_static at 0.0.4 until plotly releases a new version.
Your contribution is very helpful in maintaining compatibility. Thanks again!
As explained on #61,
plotlyis not currently compatible with version0.1ofplotly_static. The only reasonplotly_staticwas added toplotlarswas due to this bug (plotly/plotly.rs#343) that will be fixed next timeplotlygets updated and thenplotly_staticcan be dropped from this crate.Summary by CodeRabbit