Skip to content

Comments

Fix #61: Lower plotly_static version to 0.0.4#62

Merged
alceal merged 1 commit intoalceal:mainfrom
EricFecteau:main
Aug 26, 2025
Merged

Fix #61: Lower plotly_static version to 0.0.4#62
alceal merged 1 commit intoalceal:mainfrom
EricFecteau:main

Conversation

@EricFecteau
Copy link
Contributor

@EricFecteau EricFecteau commented Aug 25, 2025

As explained on #61, plotly is not currently compatible with version 0.1 of plotly_static. The only reason plotly_static was added to plotlars was due to this bug (plotly/plotly.rs#343) that will be fixed next time plotly gets updated and then plotly_static can be dropped from this crate.

Summary by CodeRabbit

  • Chores
    • Updated a plotting library dependency to a newer compatible version while retaining optional usage.
    • Improves overall dependency alignment and build consistency across environments.
    • No changes to public interfaces or features; behavior remains the same for end users.
    • Aimed to reduce potential integration friction with related packages and ensure smoother maintenance going forward.

@coderabbitai
Copy link

coderabbitai bot commented Aug 25, 2025

Walkthrough

Dependency version for plotly_static in Cargo.toml was changed from 0.1.0 to 0.0.4. The optional flag remains true. No other dependencies, features, or public interfaces were modified.

Changes

Cohort / File(s) Change summary
Dependency version update
Cargo.toml
Downgraded plotly_static from 0.1.0 to 0.0.4; kept optional = true. No other dependency or feature changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related issues

Poem

A bunny tweaked a crate today,
Hopped from one dot-one to naught-dot-four—okay!
Optional carrots still in the pack,
Dependencies snug in the stack.
With a gentle bump (well, down we go),
The garden builds—on with the show! 🥕🐇

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
Cargo.toml (2)

23-23: Sensible downgrade; consider making the exact pin explicit with "=".

Using "0.0.4" already effectively pins to exactly 0.0.4 under Cargo’s caret rules for 0.0.x, but making it explicit clarifies intent for maintainers and dependents.

-plotly_static = { version = "0.0.4", optional = true }
+plotly_static = { version = "=0.0.4", optional = true }

6-6: MSRV set to 1.86.0 looks unusually high—confirm intent.

If not intentional, consider lowering to the actual tested MSRV to avoid excluding users unnecessarily. Otherwise, document why 1.86.0 is required.

You can verify current MSRV with tools like cargo-msrv or by running CI against a matrix of Rust toolchains (e.g., stable n-2..stable).

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d6c5ac9 and 755c219.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (1)
Cargo.toml (1)

28-33: Unable to verify in CI sandbox – please confirm feature builds locally

The sandbox environment here can’t run cargo commands (no /proc/self/exe), so we’re relying on you to validate that all static‐export feature combinations still compile and link cleanly against plotly_static = "0.0.4". Please run the following in your local machine or CI and share any errors:

  • Pin plotly_static and update your lockfile:
    cargo update -p plotly_static --precise 0.0.4
  • Base check without features:
    cargo check --all-targets
  • Each static export combo:
    for feat in static_export_chromedriver static_export_geckodriver static_export_default; do
      echo "==> Checking with feature: $feat"
      cargo check --all-targets -F "$feat"
    done
  • Inspect the feature/dependency graph:
    cargo tree -e features

If any combination fails, please adjust the Cargo.toml or feature flags accordingly.

Copy link
Owner

@alceal alceal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this issue and providing the fix! I appreciate you explaining the context about the plotly bug and why we need to keep plotly_static at 0.0.4 until plotly releases a new version.

Your contribution is very helpful in maintaining compatibility. Thanks again!

@alceal alceal merged commit 91eb6f4 into alceal:main Aug 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants