Skip to content

Conversation

@dslovinsky
Copy link
Collaborator

Description

Ideally we still only need to run the changelog indexer when a file is added/removed, not modified. But this if check doesn't work, plus its hard to read and annoying to test. Existing changelog files are rarely edited after the fact anyway so we're not losing much by letting the indexer run on every change anyway.

This is not the case for other docs content, but luckily those triggers are much easier since we can just watch docs.yml changes.

Changes Made

  • remove buggy if check in changelog index gha

Testing

  • I have tested these changes locally
  • I have run the validation scripts (pnpm run validate)
  • I have checked that the documentation builds correctly

@dslovinsky dslovinsky self-assigned this Jan 15, 2026
@dslovinsky dslovinsky requested a review from a team as a code owner January 15, 2026 20:30
Copilot AI review requested due to automatic review settings January 15, 2026 20:30
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes a buggy conditional check in the changelog indexing GitHub Actions workflow that was intended to run the indexer only when files were added or removed, but was difficult to read, test, and maintain.

Changes:

  • Removed the complex if condition that checked for added/removed files in the changelog directory
  • Simplified the workflow to run on every changelog-related change instead of only add/remove operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link

github-actions bot commented Jan 15, 2026

🌿 Documentation Preview

Name Status Preview Updated (UTC)
Alchemy Docs ✅ Ready 🔗 Visit Preview Jan 15, 2026, 8:32 PM

@github-actions github-actions bot temporarily deployed to docs-preview January 15, 2026 20:31 Destroyed
@dslovinsky dslovinsky merged commit 8af0e26 into main Jan 15, 2026
8 of 9 checks passed
@dslovinsky dslovinsky deleted the ds/fix-changelog-trigger branch January 15, 2026 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants