Improve Test Coverage for packages/web3-wallet/src #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h0ngcha0
reviewed
Nov 27, 2024
Member
h0ngcha0
left a comment
h0ngcha0
left a comment
There was a problem hiding this comment.
Thanks for the contribution. Only minor comments.
| const wallet = PrivateKeyWallet.Random() | ||
| expect(wallet.address).toBeDefined() | ||
| expect(wallet.publicKey).toBeDefined() | ||
| expect(wallet.address.length).toBeGreaterThan(0) |
Member
There was a problem hiding this comment.
Lets verify the exact length of address and publicKey here.
|
|
||
| expect(signature).toBeDefined() | ||
| expect(typeof signature).toBe('string') | ||
| // Optionally add more checks to validate the signature |
Member
There was a problem hiding this comment.
Please verify if the signature is valid, we can use the verifySignature function.
pragmaxim
reviewed
Dec 3, 2024
| }) | ||
|
|
||
| it('should handle large messages for encryption and decryption', () => { | ||
| const largeMessage = 'A'.repeat(1_000_000) // 1 MB of data |
There was a problem hiding this comment.
I'd be happy with 500_000 since this single test takes 700ms (on CI it could be twice as much) and it would add up a lot in the big picture, I guess that supporting 0.5MB messages is enough
Author
|
changed @pragmaxim |
Author
|
okay ser will it be merged? @pragmaxim |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #458