Open
Conversation
Contributor
|
I don't think extra code really worth it. What kind of performance hit are we even talking about? Can you measure when does it make a difference? Also if we drop support for even more old browsers, we can just write something like this: sprintf(key, ...argv) { |
|
Well, depends a lot in the amount of consecutive calls to sprintf that you do. I'm maintaining a program that handles tens of thousands of inputs and this is a neat performance hit. I think that avoiding V8 deoptimizations is a good practice. Actually preventing V8 from optimizing functions is a really bad practice, as you don't actually know what V8 do in the back-end and if in the future they are going to add new ways of optimizations that this code will prevent. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the original code, the
argumentsobject is leaked, which disables optimization in the V8 engine. This pull request rectifies this by manually copying the passed-in arguments to a new array, keepingargumentsintact.